Upgrade VMware extension to 2024-09-01 API #8861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @jonathanhe-msft, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the VMware extension’s default API version and enhances the HCX addon commands with new networking flags, and adds a new pure-storage-volume command group in the help.
- Bump API version from
2023-09-01to2024-09-01across cluster, cloud-link, authorization, and addon commands - Add
--management-networkand--uplink-networkparameters to HCX addon create/update commands, with client‐flatten schema updates - Introduce
vmware datastore pure-storage-volumehelp entries and update release history to 8.0.0
Reviewed Changes
Copilot reviewed 167 out of 167 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cluster/_delete.py, cluster/_create.py |
Updated API version to 2024-09-01 |
cloud_link/* |
Updated API version and renamed --name flags to --cloud-link-name |
authorization/* |
Bumped API versions to 2024-09-01 |
addon/* |
Bumped API versions, added management-network & uplink-network args, enabled client_flatten |
_help.py |
Added pure-storage-volume command group help |
HISTORY.md |
Released version 8.0.0 notes |
Comments suppressed due to low confidence (3)
src/vmware/azext_vmware/aaz/latest/vmware/addon/_create.py:93
- Mark
--management-networkand--uplink-networkin the Create command as nullable=True (e.g.,nullable=True) to mirror the Update command and allow these parameters to be optional.
hcx.management_network = AAZStrArg(
src/vmware/azext_vmware/aaz/latest/vmware/addon/_create.py:93
- Add unit tests to cover the new
--management-networkand--uplink-networkparameters in the HCX create and update commands to ensure correct handling and serialization.
hcx.management_network = AAZStrArg(
src/vmware/azext_vmware/_help.py:320
- Close the quotation around the
--linked-cloudvalue in the example help text so that the shell command syntax is valid (add the missing closing").
text: az vmware datastore pure-storage-volume create --name PureStorageDatastore --resource-group MyResourceGroup --cluster Cluster-1 --private-cloud MyPrivateCloud --storage-pool-id "/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/ResourceGroup1/providers/PureStorage.Block/storagePools/storagePool1" --linked-cloud "/subscriptions/12341234-1234-1234-1234-123412341234/resourceGroups/mygroup/providers/Microsoft.AVS/privateClouds/cloud2
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
…into jonathanhe/2024-09-01
yanzhudd
approved these changes
Jun 16, 2025
cataggar
approved these changes
Jun 17, 2025
Collaborator
|
[Release] Update index.json for extension [ vmware-8.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127607402&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.